Skip to content
Snippets Groups Projects
  1. Feb 25, 2021
  2. Feb 23, 2021
  3. Feb 19, 2021
    • vlorentz's avatar
      Use dict instead of temporary SWHID when parsing {Core,Qualified}SWHID. · 99237659
      vlorentz authored
      It is cleaner, avoids warnings, and will be needed when introducing
      ExtendedSWHID in a future commit.
      99237659
    • vlorentz's avatar
      QualifiedSWHID: Replace the 'qualifiers' dict with statically defined attributes · 8e917597
      vlorentz authored
      And store their parsed values (CoreSWHID, tuple of ints, etc.) instead of string.
      8e917597
    • vlorentz's avatar
      Add new class CoreSWHID as an alternative to SWHID/QualifiedSWHID · eba8d84d
      vlorentz authored
      Following the discussion on T3034, we decided to replace SWHID with
      two or three classes:
      
      * QualifiedSWHID to replace the existing SWHID (standard types + qualifiers)
      * CoreSWHID, for "core SWHID" only (standard types + no qualifiers)
      * ExtendedSWHID for internal use in Software Heritage (extra types + no qualifiers)
      
      This commit adds the second one
      eba8d84d
    • vlorentz's avatar
      Add new class QualifiedSWHID to replace SWHID, and deprecate the latter. · 690b7f82
      vlorentz authored
      Following the discussion on T3034, we decided to replace SWHID with
      two or three classes:
      
      * QualifiedSWHID to replace the existing SWHID (standard types + qualifiers)
      * CoreSWHID, for "core SWHID" only (standard types + no qualifiers)
      * ExtendedSWHID for internal use in Software Heritage (extra types + no qualifiers)
      
      Since migrating from SWHID will break existing code, this commit uses
      the opportunity to modernize it a little, ie.:
      
      * `keyword`-only constructor, to get rid of the hacky default values for
        `object_type` and `object_id`
      * enum instead of strings for the object type
      * `bytes` instead of an hex string for the object id
      * rename `metadata` to `qualifiers`
      690b7f82
    • vlorentz's avatar
      tests: Clean hashutil._blake2_hash_cache after mocking blake2 functions. · 758eb885
      vlorentz authored
      Depending on the order in which tests are run, these tests may insert
      lambdas with mocked blake2 functions in their closure to be inserted in
      hashutil._blake2_hash_cache; causing all future tests to fail.
      
      While this does not happen with the default order of tests, it does when
      using pytest-xdist.
      758eb885
  4. Feb 02, 2021
  5. Jan 29, 2021
  6. Jan 26, 2021
  7. Jan 20, 2021
  8. Jan 14, 2021
  9. Jan 13, 2021
  10. Jan 12, 2021
    • vlorentz's avatar
      test_identifiers: Reorder SWHID tests. · 1d0c3212
      vlorentz authored
      They were mixed in with snapshot tests.
      1d0c3212
    • vlorentz's avatar
      test_identifiers: Make sure that... · 731d10d3
      vlorentz authored
      test_identifiers: Make sure that {directory,revision,release,snapshot}_identifier() doesn't just return a value from the dict.
      
      For example, before this commit, you could replace the code of
      revision_identifier() with this:
      
      def release_identifier(release):
          return release.get("id", b"")
      
      and all tests would still pass.
      731d10d3
  11. Jan 04, 2021
Loading