Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
S
swh-model
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Renaud Boyer
swh-model
Commits
fc808e1f
Commit
fc808e1f
authored
4 years ago
by
vlorentz
Browse files
Options
Downloads
Patches
Plain Diff
model: Add 'id' field to RawExtrinsicMetadata
So that they can be properly deduplicated and referenced.
parent
f6eab952
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
swh/model/model.py
+7
-1
7 additions, 1 deletion
swh/model/model.py
swh/model/tests/test_model.py
+6
-1
6 additions, 1 deletion
swh/model/tests/test_model.py
with
13 additions
and
2 deletions
swh/model/model.py
+
7
−
1
View file @
fc808e1f
...
...
@@ -21,6 +21,7 @@ from .identifiers import (
directory_identifier
,
normalize_timestamp
,
origin_identifier
,
raw_extrinsic_metadata_identifier
,
release_identifier
,
revision_identifier
,
snapshot_identifier
,
...
...
@@ -881,7 +882,7 @@ class MetadataFetcher(BaseModel):
@attr.s
(
frozen
=
True
,
slots
=
True
)
class
RawExtrinsicMetadata
(
BaseModel
):
class
RawExtrinsicMetadata
(
HashableObject
,
BaseModel
):
object_type
:
Final
=
"
raw_extrinsic_metadata
"
# target object
...
...
@@ -913,6 +914,11 @@ class RawExtrinsicMetadata(BaseModel):
type
=
Optional
[
CoreSWHID
],
default
=
None
,
validator
=
type_validator
()
)
id
=
attr
.
ib
(
type
=
Sha1Git
,
validator
=
type_validator
(),
default
=
b
""
)
def
compute_hash
(
self
)
->
bytes
:
return
hash_to_bytes
(
raw_extrinsic_metadata_identifier
(
self
.
to_dict
()))
@discovery_date.validator
def
check_discovery_date
(
self
,
attribute
,
value
):
"""
Checks the discovery_date has a timezone.
"""
...
...
This diff is collapsed.
Click to expand it.
swh/model/tests/test_model.py
+
6
−
1
View file @
fc808e1f
...
...
@@ -819,7 +819,9 @@ _origin_swhid = ExtendedSWHID.from_string(
)
_dummy_qualifiers
=
{
"
origin
"
:
"
https://example.com
"
,
"
lines
"
:
"
42
"
}
_common_metadata_fields
=
dict
(
discovery_date
=
datetime
.
datetime
.
now
(
tz
=
datetime
.
timezone
.
utc
),
discovery_date
=
datetime
.
datetime
(
2021
,
1
,
29
,
13
,
57
,
9
,
tzinfo
=
datetime
.
timezone
.
utc
),
authority
=
_metadata_authority
,
fetcher
=
_metadata_fetcher
,
format
=
"
json
"
,
...
...
@@ -853,6 +855,7 @@ def test_metadata_to_dict():
m
=
RawExtrinsicMetadata
(
target
=
_origin_swhid
,
**
_common_metadata_fields
,)
assert
m
.
to_dict
()
==
{
"
target
"
:
str
(
_origin_swhid
),
"
id
"
:
b
"
\xec
k
\x9c
Q
\xf1\x1f\xeb\xde\x85
{
\x7f\xf0\x83\x9c\x8a\xd5\xfb\x8e
2
\xef
"
,
**
common_fields
,
}
assert
RawExtrinsicMetadata
.
from_dict
(
m
.
to_dict
())
==
m
...
...
@@ -860,6 +863,7 @@ def test_metadata_to_dict():
m
=
RawExtrinsicMetadata
(
target
=
_content_swhid
,
**
_common_metadata_fields
,)
assert
m
.
to_dict
()
==
{
"
target
"
:
"
swh:1:cnt:94a9ed024d3859793618152ea559a168bbcbb5e2
"
,
"
id
"
:
b
"
\x8e
:_;eb
\xe6\xf1
Y
\xd9\xa5
aG[
\r
t
\x89\xa1\x0b\xe4
"
,
**
common_fields
,
}
assert
RawExtrinsicMetadata
.
from_dict
(
m
.
to_dict
())
==
m
...
...
@@ -878,6 +882,7 @@ def test_metadata_to_dict():
)
assert
m
.
to_dict
()
==
{
"
target
"
:
"
swh:1:cnt:94a9ed024d3859793618152ea559a168bbcbb5e2
"
,
"
id
"
:
b
"
\x07\xf1
aS
\xbe\xda\xd2\xf2\xd7\xaf
:
\xc7\xb7\x91
C
\x87
W
\x85
R
\x19
"
,
**
common_fields
,
"
origin
"
:
"
https://example.org/
"
,
"
snapshot
"
:
f
"
swh:1:snp:
{
hash_hex
}
"
,
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment