Skip to content
Snippets Groups Projects
  1. Jan 26, 2021
  2. Jan 20, 2021
  3. Jan 14, 2021
  4. Jan 13, 2021
  5. Jan 12, 2021
    • vlorentz's avatar
      test_identifiers: Reorder SWHID tests. · 1d0c3212
      vlorentz authored
      They were mixed in with snapshot tests.
      1d0c3212
    • vlorentz's avatar
      test_identifiers: Make sure that... · 731d10d3
      vlorentz authored
      test_identifiers: Make sure that {directory,revision,release,snapshot}_identifier() doesn't just return a value from the dict.
      
      For example, before this commit, you could replace the code of
      revision_identifier() with this:
      
      def release_identifier(release):
          return release.get("id", b"")
      
      and all tests would still pass.
      731d10d3
  6. Jan 04, 2021
  7. Dec 30, 2020
    • Stefano Zacchiroli's avatar
      SWHID parsing: simplify and deduplicate validation logic · 57468505
      Stefano Zacchiroli authored
      Before this change there was a lot of overlap between parse_swhid() and the
      attrs-based validators in the SWHID class. Also, the validation implementation
      in parse_swhid() was done by hand.
      
      With this change the coarse-grained validation done by parse_swhid() is now
      delegated to a regex. The semantic validation of SWHIDs is left to attrs
      validators. The regex is also exposed as a module attribute, to be used by
      client code that want to syntactically validate SWHIDs without necessarily
      instantiate SWHID classes (we have several other modules doing that already,
      and they are using slightly different hand-made regexs, which isn't great).
      
      As part of this change we also clean up the use of ValidationError exceptions,
      systematically passing the problematic parts of SWHID as arguments, and uniform
      error messages.
      
      This change also brings some speed up in SWHID parsing. On a benchmark parsing
      ~30 M valid SWHIDs, the previous implementation took ~3:06 minutes, the new one
      ~2:50 minutes, or a ~9% speedup.
      
      Closes T2788
      57468505
  8. Dec 15, 2020
    • vlorentz's avatar
      model: Make all classes slotted. · 76b744e0
      vlorentz authored
      Unfortunately, sphinx (actually, autodoc) only picks up attributes if
      they fall in any of these cases:
      
      1. are enum variants
      2. are in slots
      3. are in __dict__
      4. have an annotation
      5. are found using its custom parser
      
      (see get_object_members in sphinx/ext/autodoc/importer.py)
      
      In theory, option 5 should work for us; unfortunately, autodoc only
      asks the parser the list of members with a comment.
      And it's not easy to adapt it to ask the parser for all members,
      because said parser (sphinx/pycode/parser.py) does not return the class
      qualname (aka. namespace) for members without comments.
      
      So, as I don't want to change the interface of sphinx.pycode.parser,
      this commit switches to relying on option 3, by adding __slots__ for
      all attr classes.
      
      Additionally, this might have some performance/memory improvement
      (though I did not check) and will further avoid mutation of these
      objects.
      76b744e0
  9. Nov 17, 2020
  10. Nov 16, 2020
  11. Nov 12, 2020
  12. Nov 10, 2020
  13. Oct 27, 2020
  14. Oct 26, 2020
  15. Oct 23, 2020
Loading