inbound_email: GET is not allowed

swh/web/inbound_email/tests/test_views.py

@@ -3,13 +3,14 @@
 # License: GNU Affero General Public License version 3, or any later version
 # See top-level LICENSE file for more information
 
+from http import HTTPStatus
 from io import BytesIO
 
 import pytest
 
 from django.test.client import MULTIPART_CONTENT
 
-from swh.web.tests.helpers import check_http_post_response
+from swh.web.tests.helpers import check_http_get_response, check_http_post_response
 from swh.web.utils import reverse
 
 from .common_tests import *  # noqa
@@ -22,7 +23,7 @@ def receive_inbound_message(client, inbound_message):
         check_http_post_response(
             client,
             url,
-            status_code=400 if expect_failure else 200,
+            status_code=HTTPStatus.BAD_REQUEST if expect_failure else HTTPStatus.OK,
             request_content_type=MULTIPART_CONTENT,
             data={"shared_key": shared_key, "email": BytesIO(inbound_message)},
         )
@@ -42,3 +43,11 @@ def test_empty_email(receive_inbound_message):
 def test_invalid_shared_key(receive_inbound_message):
     with pytest.raises(AssertionError, match="Invalid shared key!"):
         receive_inbound_message(shared_key="invalid")
+
+
+def test_get_is_not_allowed(client):
+    check_http_get_response(
+        client,
+        reverse("process-inbound-email"),
+        status_code=HTTPStatus.METHOD_NOT_ALLOWED,
+    )

swh/web/inbound_email/views.py

@@ -33,6 +33,7 @@ class InboundEmailForm(forms.Form):
 class InboundEmailView(FormMixin, ProcessFormView):
     form_class = InboundEmailForm
     success_url = "/"
+    http_method_names = ["post", "put"]  # no blank (get) InboundEmailForm view
 
     def form_invalid(self, form):
         return HttpResponseBadRequest(