Skip to content
GitLab
Explore
Sign in
Register
Primary navigation
Search or go to…
Project
S
swh-web
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
David Douard
swh-web
Commits
13ae217e
Commit
13ae217e
authored
1 year ago
by
Antoine Lambert
Browse files
Options
Downloads
Patches
Plain Diff
add_forge_now: Ensure to draw requests table on init when user logged
User requests filter was still taken into account otherwise.
parent
8b8a0c65
No related branches found
Branches containing commit
Tags
debian/1.10.0-1_swh1_bpo10+1
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
cypress/e2e/add-forge-now-request-create.cy.js
+12
-1
12 additions, 1 deletion
cypress/e2e/add-forge-now-request-create.cy.js
swh/web/add_forge_now/assets/create-request.js
+1
-0
1 addition, 0 deletions
swh/web/add_forge_now/assets/create-request.js
with
13 additions
and
1 deletion
cypress/e2e/add-forge-now-request-create.cy.js
+
12
−
1
View file @
13ae217e
...
...
@@ -92,6 +92,17 @@ describe('Browse requests list tests', function() {
// user requests filter checkbox should be in the DOM
cy
.
get
(
'
#swh-add-forge-requests-list-tab
'
).
click
();
cy
.
get
(
'
#swh-add-forge-user-filter
'
).
should
(
'
exist
'
);
cy
.
wait
(
'
@addForgeRequestsList
'
);
// ensure datatable got rendered
cy
.
wait
(
100
);
// check unfiltered user requests
cy
.
get
(
'
tbody tr
'
).
then
(
rows
=>
{
expect
(
rows
.
length
).
to
.
eq
(
3
);
});
// activate filter
cy
.
get
(
'
#swh-add-forge-user-filter
'
).
check
({
force
:
true
});
cy
.
get
(
'
#swh-add-forge-user-filter
'
).
should
(
'
be.checked
'
);
...
...
@@ -99,7 +110,7 @@ describe('Browse requests list tests', function() {
// ensure datatable got rendered
cy
.
wait
(
100
);
// check
un
filtered user requests
// check filtered user requests
cy
.
get
(
'
tbody tr
'
).
then
(
rows
=>
{
expect
(
rows
.
length
).
to
.
eq
(
2
);
});
...
...
This diff is collapsed.
Click to expand it.
swh/web/add_forge_now/assets/create-request.js
+
1
−
0
View file @
13ae217e
...
...
@@ -92,6 +92,7 @@ export function populateRequestBrowseList() {
$
(
`#
${
addForgeCheckboxId
}
`
).
on
(
'
change
'
,
()
=>
{
requestBrowseTable
.
draw
();
});
requestBrowseTable
.
draw
();
}
},
columns
:
[
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment