Skip to content
Snippets Groups Projects
Commit b2ff630c authored by Nicolas Dandrimont's avatar Nicolas Dandrimont
Browse files

debian: refactor inner loop slightly to help mypy

mypy doesn't catch that multiple uses of
`self.listed_origins[origin_url]` in the same statement should be identical.
Using a temporary local variable for it seems to help.
parent 0e7fdf48
No related branches found
No related tags found
No related merge requests found
...@@ -232,11 +232,13 @@ class DebianLister(Lister[DebianListerState, DebianPageType]): ...@@ -232,11 +232,13 @@ class DebianLister(Lister[DebianListerState, DebianPageType]):
self.package_versions[package_name] = set() self.package_versions[package_name] = set()
# origin will be yielded at the end of that method # origin will be yielded at the end of that method
origins_to_send[origin_url] = self.listed_origins[origin_url] current_origin = origins_to_send[origin_url] = self.listed_origins[
origin_url
]
# update package versions data in parameter that will be provided # update package versions data in parameter that will be provided
# to the debian loader # to the debian loader
self.listed_origins[origin_url].extra_loader_arguments["packages"].update( current_origin.extra_loader_arguments["packages"].update(
{ {
package_version_key: { package_version_key: {
"name": package_name, "name": package_name,
...@@ -246,14 +248,13 @@ class DebianLister(Lister[DebianListerState, DebianPageType]): ...@@ -246,14 +248,13 @@ class DebianLister(Lister[DebianListerState, DebianPageType]):
} }
) )
if self.listed_origins[origin_url].last_update is None or ( if current_origin.last_update is None or (
self.last_sources_update is not None self.last_sources_update is not None
and self.last_sources_update # type: ignore and self.last_sources_update > current_origin.last_update
> self.listed_origins[origin_url].last_update
): ):
# update debian package last update if current processed sources index # update debian package last update if current processed sources index
# has a greater modification date # has a greater modification date
self.listed_origins[origin_url].last_update = self.last_sources_update current_origin.last_update = self.last_sources_update
# add package version key to the set of found versions # add package version key to the set of found versions
self.package_versions[package_name].add(package_version_key) self.package_versions[package_name].add(package_version_key)
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment