From d938bcda635b229421d8ae23623f8a295b9a812d Mon Sep 17 00:00:00 2001
From: "Antoine R. Dumont (@ardumont)" <ardumont@softwareheritage.org>
Date: Thu, 13 Feb 2025 15:57:23 +0100
Subject: [PATCH] rancher-node-staging-rke2-metal02/zfs: Keep some disks as
 spare 2/2

Let's try to see whether the comment is the source of the issue.

```
Error: Execution of '/usr/sbin/zpool create data mirror wwn-0x500080d9111ee825 wwn-0x500080d9111ee979 mirror wwn-0x500080d9111ee839 wwn-0x500080d9111ee96e mirror wwn-0x500080d9111ee952 wwn-0x500080d9111ee93b spar
e wwn-0x500080d9111ee92b wwn-0x500080d9111ee829' returned 1: invalid vdev specification
use '-f' to override the following errors:
/dev/disk/by-id/wwn-0x500080d9111ee92b contains a filesystem of type 'LVM2_member'
Error: /Stage[main]/Profile::Zfs::Common/Zpool[data]/ensure: change from 'absent' to 'present' failed: Execution of '/usr/sbin/zpool create data mirror wwn-0x500080d9111ee825 wwn-0x500080d9111ee979 mirror wwn-0x5
00080d9111ee839 wwn-0x500080d9111ee96e mirror wwn-0x500080d9111ee952 wwn-0x500080d9111ee93b spare wwn-0x500080d9111ee92b wwn-0x500080d9111ee829' returned 1: invalid vdev specification
use '-f' to override the following errors:
/dev/disk/by-id/wwn-0x500080d9111ee92b contains a filesystem of type 'LVM2_member'
```

Refs. swh/infra/sysadm-environment#5547
---
 ...ode-staging-rke2-metal02.internal.staging.swh.network.yaml | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/data/hostname/rancher-node-staging-rke2-metal02.internal.staging.swh.network.yaml b/data/hostname/rancher-node-staging-rke2-metal02.internal.staging.swh.network.yaml
index b7ecfea42..34464e0a5 100644
--- a/data/hostname/rancher-node-staging-rke2-metal02.internal.staging.swh.network.yaml
+++ b/data/hostname/rancher-node-staging-rke2-metal02.internal.staging.swh.network.yaml
@@ -15,14 +15,14 @@ mountpoints:
 
 swh::apt_config::enable_non_free: true
 
+# The 'spare' data disks are not used as we may want to unplug them from this
+# node and plug them in other machines (e.g. branly).
 zfs::common::zpool_configuration:
   mirror:
     - wwn-0x500080d9111ee825 wwn-0x500080d9111ee979
     - wwn-0x500080d9111ee839 wwn-0x500080d9111ee96e
     - wwn-0x500080d9111ee952 wwn-0x500080d9111ee93b
   spare:
-    # Those are not used as we may want to unplug them and plug them to other
-    # machines
     - wwn-0x500080d9111ee92b
     - wwn-0x500080d9111ee829
 
-- 
GitLab