swh/model/tests/test_swh_model_data.py

@@ -6,6 +6,7 @@
 import attr
 import pytest
 
+from swh.model.model import ModelObjectType
 from swh.model.tests.swh_model_data import TEST_OBJECTS
 
 
@@ -18,7 +19,23 @@ def test_swh_model_data(object_type, objects):
         attr.validate(obj)
 
 
-def test_ensure_visit_visit_status_date_consistency():
+@pytest.mark.parametrize(
+    "object_type",
+    (
+        ModelObjectType.DIRECTORY,
+        ModelObjectType.REVISION,
+        ModelObjectType.RELEASE,
+        ModelObjectType.SNAPSHOT,
+    ),
+)
+def test_swh_model_data_hash(object_type):
+    for obj in TEST_OBJECTS[object_type]:
+        assert (
+            obj.compute_hash() == obj.id
+        ), f"{obj.compute_hash().hex()} != {obj.id.hex()}"
+
+
+def test_ensure_visit_status_date_consistency():
     """ensure origin-visit-status dates are more recent than their visit counterpart
 
     The origin-visit-status dates needs to be shifted slightly in the future from their
@@ -27,9 +44,17 @@ def test_ensure_visit_visit_status_date_consistency():
     parameters from the origin-visit {origin, visit, date}...
 
     """
-    visits = TEST_OBJECTS["origin_visit"]
-    visit_statuses = TEST_OBJECTS["origin_visit_status"]
+    visits = TEST_OBJECTS[ModelObjectType.ORIGIN_VISIT]
+    visit_statuses = TEST_OBJECTS[ModelObjectType.ORIGIN_VISIT_STATUS]
     for visit, visit_status in zip(visits, visit_statuses):
         assert visit.origin == visit_status.origin
         assert visit.visit == visit_status.visit
         assert visit.date < visit_status.date
+
+
+def test_ensure_visit_status_snapshot_consistency():
+    """ensure origin-visit-status snapshots exist in the test dataset"""
+    snapshots = [snp.id for snp in TEST_OBJECTS[ModelObjectType.SNAPSHOT]]
+    for visit_status in TEST_OBJECTS[ModelObjectType.ORIGIN_VISIT_STATUS]:
+        if visit_status.snapshot:
+            assert visit_status.snapshot in snapshots