From 39296ace048a9c2bfef6868444553c5aa6cf4859 Mon Sep 17 00:00:00 2001
From: Pierre-Yves David <pierre-yves.david@ens-lyon.org>
Date: Mon, 13 May 2024 15:24:14 +0200
Subject: [PATCH] test: fix bogus "tzfile" representation on the fly in
test_repr
Check inline comment for details.
---
swh/model/tests/test_model.py | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/swh/model/tests/test_model.py b/swh/model/tests/test_model.py
index 38caf19c..5b71f455 100644
--- a/swh/model/tests/test_model.py
+++ b/swh/model/tests/test_model.py
@@ -7,6 +7,7 @@ import collections
import copy
import datetime
import hashlib
+import re
from typing import Any, List, Optional, Tuple, Union
import attr
@@ -82,6 +83,18 @@ def test_todict_inverse_fromdict(objtype_and_obj):
assert obj_as_dict == type(obj).from_dict(obj_as_dict).to_dict()
+# In some case, python-dateutil build a `tzfile` object from the
+# content of a tarball. In such case the `tzfile._filename` attribute will refer to the
+# filepath within the tarball, making the __repr__ unusable. We work around
+# this by replacing the tzfile by a gettz call, as the filename matches the
+# timezone identifier.
+#
+# We detect the bogus tzfile __repr__ by checking if the path is absolute. If
+# the path is not absolute, we are in the tarball case.
+
+RE_FIX_TZ_FILE = re.compile(r"tzfile\('([^/][^']*)'\)")
+
+
@given(strategies.objects())
def test_repr(objtype_and_obj):
"""Checks every model object has a working repr(), and that it can be eval()uated
@@ -92,10 +105,13 @@ def test_repr(objtype_and_obj):
env = {
"tzutc": lambda: datetime.timezone.utc,
"tzfile": dateutil.tz.tzfile,
+ "gettz": dateutil.tz.gettz,
"hash_to_bytes": hash_to_bytes,
**swh.model.swhids.__dict__,
**swh.model.model.__dict__,
}
+ # replace bogus tzfile __repr__ on the fly
+ r = RE_FIX_TZ_FILE.sub(r"gettz('\1')", r)
assert eval(r, env) == obj
--
GitLab