diff --git a/swh/deposit/api/common.py b/swh/deposit/api/common.py index 432b64aefd924840b6c002624f37b01d574cf3da..7e970d0517d396c41c368d847203905de49a3038 100644 --- a/swh/deposit/api/common.py +++ b/swh/deposit/api/common.py @@ -1018,9 +1018,7 @@ class APIBase(APIConfig, APIView, metaclass=ABCMeta): if self._client is None: try: - self._client = DepositClient.objects.get( # type: ignore - username=username - ) + self._client = DepositClient.objects.get(username=username) except DepositClient.DoesNotExist: raise DepositError(NOT_FOUND, f"Unknown client name {username}") diff --git a/swh/deposit/cli/admin.py b/swh/deposit/cli/admin.py index 594ca17723a6859b9ce5ec6c2d4a972685f1f73f..7e0735b500191017d8a5dc62bb01d930f5963b94 100644 --- a/swh/deposit/cli/admin.py +++ b/swh/deposit/cli/admin.py @@ -114,7 +114,7 @@ def user_create( # user create/update try: - user = DepositClient.objects.get(username=username) # type: ignore + user = DepositClient.objects.get(username=username) click.echo(f"Update user '{username}'.") action_done = "updated" except DepositClient.DoesNotExist: @@ -166,7 +166,7 @@ def user_exists(ctx, username: str): from swh.deposit.models import DepositClient try: - DepositClient.objects.get(username=username) # type: ignore + DepositClient.objects.get(username=username) click.echo(f"User {username} exists.") ctx.exit(0) except DepositClient.DoesNotExist: diff --git a/swh/deposit/tests/conftest.py b/swh/deposit/tests/conftest.py index e858a1214cc1967e3e34f78e8e71bccba1e22a83..5f13a6c64a8098dc864682ebb3ca36e8b45ce71d 100644 --- a/swh/deposit/tests/conftest.py +++ b/swh/deposit/tests/conftest.py @@ -264,7 +264,7 @@ def _create_deposit_user( user_data_d = deepcopy(user_data) user_data_d.pop("collection", None) passwd = user_data_d.pop("password", None) - user, _ = DepositClient.objects.get_or_create( # type: ignore + user, _ = DepositClient.objects.get_or_create( username=user_data_d["username"], defaults={**user_data_d, "collections": [collection.id]}, ) diff --git a/tox.ini b/tox.ini index 2eba668fabe8d9381fd51d64f83f01333caf3717..a761fbf44065a4f4a6299c142e9973fbe33458e5 100644 --- a/tox.ini +++ b/tox.ini @@ -41,7 +41,7 @@ setenv = DJANGO_SETTINGS_MODULE=swh.deposit.settings.testing extras = testing deps = - mypy==0.942 + mypy==1.0 commands = mypy swh